Add a project version to the build. #887
Conversation
There was a problem hiding this comment.
I don't feel strongly about this but I think there is no need for a separate library, unless you have plans for using it elsewhere later?
But since you've already put in the effort to add a new library I don't think we necessarily need to simplify this down to a single header.
|
There have already been significant changes since version 0.7 (including adding the new config system), so I wonder if we'd be better off calling it 0.8.0-dev or something along those lines. See #109 for lots of discussion about a version string. |
pmundkur
force-pushed
the
version_info
branch
2 times, most recently
from
89ba1b6 to
0876fb4
Compare
cmake/project_version.cmake
Outdated
| ) | ||
|
|
||
| if (git_error) | ||
| message(FATAL_ERROR "Failed to run git describe: ${git_error}") |
There was a problem hiding this comment.
This means you can no longer build the downloaded archive.
There was a problem hiding this comment.
This means you can no longer build the downloaded archive.
Should be fixed now.
pmundkur
force-pushed
the
version_info
branch
3 times, most recently
from
ffeffce to
b046baa
Compare
Unfortunately, a "-dev" suffix doesn't quite work with CMake's semver check, nor does |
| @@ -0,0 +1,45 @@ | |||
| # Set a default version for archive builds that do not have | |||
| # git history. Increment this appropriately at tag-and-release time. | |||
There was a problem hiding this comment.
If we have to do this anyway is there much benefit to using git describe?
I wonder if it's simpler just to update it manually.
cmake/project_version.cmake
Outdated
| set(archive_build_version "0.7.0") | ||
|
|
||
| # Sets GIT_EXECUTABLE | ||
| find_package(Git REQUIRED) |
There was a problem hiding this comment.
Probably shouldn't be required? If git isn't found just use the archive_build_version.
Uses `git describe` to get the version according to git, and sanitizes it for CMake project function for potential future use with CPack. Adds an option to the c_emulator to report the (git) version. This requires the github checkout action to fetch a clean history at least upto the last tag. For now, fetch all history. For builds of a downloaded archive without git history, use a specified version.
The last release on github used 0.7, so the version is set to 0.7.0.
Add an option to the c_emulator to report the version.